change #include <unzip.h> to #include <minizip/unzip.h>#274
Open
Architector4 wants to merge 4 commits intocortex-command-community:developmentfrom
Open
change #include <unzip.h> to #include <minizip/unzip.h>#274Architector4 wants to merge 4 commits intocortex-command-community:developmentfrom
Architector4 wants to merge 4 commits intocortex-command-community:developmentfrom
Conversation
Contributor
Author
|
msbuild go shit yourself i had a rough day ok |
This should have been causing issues for a while, unknown why it hasn't yet. The changes to minizip pkg-config that make this necessary are already 2y old and are already part of the previous release tag.
HeliumAnt
previously approved these changes
Mar 5, 2026
s20610
added a commit
to s20610/Cortex-Command-Vibe-Wars
that referenced
this pull request
Mar 29, 2026
build(minizip): use SYSTEM_MINIZIP header paths on linux/darwin (PR cortex-command-community#274)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
oh my lord lmao edit: what the FUCK |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
tf is going on with this :( |
Contributor
|
macports has a broken version of the minizip package, there's already a fixed version of the package available (within hours of the broken release and already for a month), but it's somehow still using the broken version (the broken release has ~5 downloads this month and I think thats all ours) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets the codebase built on my Arch Linux system again. HeliumAnt said it should be fine to do this lmao